-
-
Notifications
You must be signed in to change notification settings - Fork 504
Issue 75: Autostart of Everything when it's not launched #676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Issue 75: Autostart of Everything when it's not launched #676
Conversation
|
Hello @srwi |
srwi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @codingonHP, thanks for the contribution and for taking on the oldest unresolved issue. 🙂
I tried your changes and while they do work, there is a small issue: When opening the search window while Everything is not already running in the background, the search UI freezes while Everything is starting up. Because of that I was not able to see the progress bar at all. This may not be as noticable for users who use Everything often (short startup times), but for those who rarely use it, the program will usually start by reindexing the database, which causes the freeze to last much longer.
Instead of adding a new progress bar to the UI, I think you can reuse the existing busy indicator in SearchResultsView. To do that, you can integrate your code into the Initialize method in SearchResultsProvider and set the IsBusy flag to true while Everything is starting up.
| public static class EverythingProcessHelper | ||
| { | ||
| private const string Dll64 = "Everything64.dll"; | ||
| private const string Dll32 = "Everything32.dll"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EverythingToolbar doesn't support 32 bit machines, so you can just remove code related to that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed code for 32 bit. Thanks
| return; | ||
| } | ||
|
|
||
| string[] possiblePaths = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Everything path should already be stored in settings:
| [Option(DefaultValue = "C:\\Program Files\\Everything\\Everything.exe")] |
I like your use of fallback values but you may want to prioritize the stored location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prioritized user settings and then fallbacks will follow. Thanks
|
Thanks @srwi for the review. I was off for couple of days. I will check the PR comments |
srwi#75 If Everything is not running then run it in background first.
I have tried adding |
d114bfc to
a25acef
Compare
Ref: #75
Changes:
EnsureRunning()whenever SearchWindow is Activated